Implement external timeseries for Delwaq coupling #1111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evetion
changed the title
evetion
added
control
|
Closed in favour of #1137 (which show how these fields can be used). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #520
Required for reading in results from (and possibly input to) Delwaq (#649), which can be used in coupling.
This adds a generic External, node_id less Node, with only a time table, with fields
timeandexternal. It can be used as a global condition (climate forcing?). Furthermore, this adds a singleconcentrationcolumn to the Basin static/time tables. This can be used as both input for Delwaq coupling, as output from the Delwaq model.The code for both inputs is very similar, hence the combined PR. Both inputs are now hardcoded single names, as a generic dynamic solution seems much more complex. Eventually we want to have several concentration/input fields, for setting multiple tracers.