Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mean output flows #1159

Merged
merged 28 commits into from
Feb 28, 2024
Merged

Mean output flows #1159

merged 28 commits into from
Feb 28, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #935.

@SouthEndMusic SouthEndMusic marked this pull request as draft February 21, 2024 12:54
@SouthEndMusic
Copy link
Collaborator Author

SouthEndMusic commented Feb 21, 2024

To do:

core/src/callback.jl Outdated Show resolved Hide resolved
core/test/time_test.jl Outdated Show resolved Hide resolved
@SouthEndMusic
Copy link
Collaborator Author

SouthEndMusic commented Feb 22, 2024

To do:
- [ ] Remove horizontal flows from flow output

  • Update docstrings and documentation

core/src/callback.jl Outdated Show resolved Hide resolved
@SouthEndMusic SouthEndMusic requested a review from visr February 26, 2024 13:42
@SouthEndMusic SouthEndMusic marked this pull request as ready for review February 26, 2024 13:42
docs/core/usage.qmd Outdated Show resolved Hide resolved
docs/core/usage.qmd Show resolved Hide resolved
docs/core/numerics.qmd Outdated Show resolved Hide resolved
docs/core/modelconcept.qmd Outdated Show resolved Hide resolved
core/src/config.jl Outdated Show resolved Hide resolved
core/test/equations_test.jl Outdated Show resolved Hide resolved
core/test/run_models_test.jl Outdated Show resolved Hide resolved
core/test/run_models_test.jl Outdated Show resolved Hide resolved
core/src/callback.jl Outdated Show resolved Hide resolved
core/src/callback.jl Outdated Show resolved Hide resolved
@SouthEndMusic SouthEndMusic requested a review from visr February 28, 2024 07:43
Comment on lines 240 to +242
elseif saveat == Inf
# only the start and end
[0.0, t_end]
saveat = [0.0, t_end]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be simpler to return t_end (or perhaps [t_end]) here instead of filtering the 0.0 out for the SavingCallback?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether that's desirable since saveat is also used for the save subgrid level callback.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was thinking for that we can use save start = true

core/test/run_models_test.jl Outdated Show resolved Hide resolved
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some optional final suggestions.

@SouthEndMusic SouthEndMusic merged commit 51ed6ed into main Feb 28, 2024
17 of 18 checks passed
@SouthEndMusic SouthEndMusic deleted the mean_flow_output branch February 28, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change flow results from instantaneous to average over past timestep
2 participants