Rename TargetLevel again: LevelDemand #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hofer-Julian
approved these changes
Feb 23, 2024
Hofer-Julian
pushed a commit
that referenced
this pull request
Feb 23, 2024
This was a pain to rename. I manually edited quite a bit. I prefer to always refer to the node types by their proper PascalCase name in comments and docs, so Basin and not basin. A part of the allocation docs were also outdated, referring to only User nodes, whereas it should refer to all Demand nodes. Rename suggested by @gijsber and on top of #1172. PR is ready for review, I'll still add upgrade instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1082 and #1141.
As suggested by @gijsber, to go with FlowDemand of #78, and renaming User to UserDemand.
Not breaking since the TargetLevel node has not yet been in a release.