Write full Node table once #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hofer-Julian
pushed a commit
that referenced
this pull request
Mar 26, 2024
The idea was that the Node table `fid` would not be used anymore, but #1306 showed that is unfortunately not yet the case. So this changes the `fid` after it is initially written to be equal to the `node_id`. Any users should still not rely on the `fid`, because this is only temporary. This is like #1311 but now also catching non unique node IDs on `model.write`. It also provides a temporary fix to #1306. It's not great, but I feel that especially #1306 is bad enough to warrant a quick fix. This would've been a bit cleaner to implement using #1312 to avoid having to read and re-write the Node table, but that PR still has issues we don't understand, so best not to wait on that. 
Hofer-Julian
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.