Add model.to_xugrid()
#1314
Merged
Add model.to_xugrid()
#1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code assumes globally unique node IDs, so I added it to the list at #1318. An additional complication is that MDAL currently doesn't support (variable length?) strings as coordinate variables, so just adding |
9 tasks
Hofer-Julian
approved these changes
Mar 26, 2024
Huite
approved these changes
Mar 26, 2024
Co-authored-by: Hofer-Julian <[email protected]>
Huite
reviewed
Mar 26, 2024
Huite
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional dependency on
xugrid, to facilitate creating UGRID netCDFs, to support #969.For now I did not yet add any results to the dataset, but this could be done as a follow-up. This is just the network.