Minimal pixi default environment #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only add dependencies to the default environment that are necessary to test Ribasim Python or Ribasim API. This should make it easier to keep track of which dependencies are necessary for what and also reduce solve times.
Hofer-Julian
commented
Mar 26, 2024
| @@ -35,7 +35,7 @@ First, set up pixi as described on their getting started [page](https://prefix.d | |||
| Then set up the environment by running the following commands: | |||
|
|
|||
| ```sh | |||
| pixi run install | |||
| pixi run --environment=dev install | |||
There was a problem hiding this comment.
This is only necessary because otherwise the editable install installs into the wrong environment.
As soon as pixi supports editable installs this will not be necessary anymore.
There was a problem hiding this comment.
Perhaps it's good to create an issue for this, with a reminder to remove this.
Do we now already use the new minimal default environment anywhere in CI, or do we use |
visr
approved these changes
Mar 26, 2024
Ribasim Python tests use it. |
|
The lock file became a lot smaller: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only add dependencies to the default environment that are necessary to test Ribasim Python or Ribasim API. This should make it easier to keep track of which dependencies are necessary for what, and also reduce solve times.