Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Model.to_crs method in order to reproject #1360

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Add Model.to_crs method in order to reproject #1360

merged 3 commits into from
Apr 8, 2024

Conversation

Hofer-Julian
Copy link
Contributor

Fixes #1354

@Hofer-Julian Hofer-Julian marked this pull request as ready for review April 8, 2024 09:15
@Hofer-Julian Hofer-Julian requested review from evetion and visr April 8, 2024 09:15
evetion
evetion requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@evetion evetion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly little code. I dislike getattr stuff a bit, but not enough to block it.

@Hofer-Julian
Copy link
Contributor Author

I dislike getattr stuff a bit, but not enough to block it.

I am not attached to it. Happy to hear alternative suggestions @evetion

@Hofer-Julian Hofer-Julian merged commit 2adaec4 into main Apr 8, 2024
24 checks passed
@Hofer-Julian Hofer-Julian deleted the to-crs branch April 8, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr left review comments

@evetion evetion evetion requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Model.to_crs method in order to reproject
3 participants
@Hofer-Julian @visr @evetion