Sort only Edge fid so edge_id becomes more stable #1363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we sorted the Edge table like this:
This made it appear a bit more neat, though it served no other purpose.
The
fid
index was mostly an implementation detail that the user did not specify, and it went from 1:n following the sorting above. Howeverfid
becomesedge_id
in the flow.arrow. Therefore when a users added a new edge, usually half of alledge_id
s changed, making post-processing unnecessarily difficult. Therefore this PR removes this sorting, such that the input order is retained, keeping the oldedge_id
s stable.With this I think we can close #1310. It is useful to have a single identifier value for an Edge, even though it is somewhat superfluous. With this PR it becomes stable, unless users start modifying
fid
s themselves.