Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tolerance to subnetwork demands test #1384

Closed
wants to merge 1 commit into from
Closed

Add tolerance to subnetwork demands test #1384

wants to merge 1 commit into from

Conversation

visr
Copy link
Member

@visr visr commented Apr 15, 2024

Fixes CI on main. See also #1383.

@visr visr requested a review from SouthEndMusic April 15, 2024 08:13
SouthEndMusic
SouthEndMusic approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@SouthEndMusic SouthEndMusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but better wait until all checks are green 😋

@visr visr mentioned this pull request Apr 15, 2024
Closed
@visr visr closed this Apr 15, 2024
@visr visr mentioned this pull request Apr 15, 2024
Merged
visr added a commit that referenced this pull request Apr 15, 2024
@visr
Revert "Equal ratio allocation objective (#1366)" (#1385)
0574470 
This reverts commit 19139f1,
#1366.

It introduced some non-deterministic failures, that would be best to
investigate outside of main.

See #1383. To land this again
we should also include #1384,
which addressed one of the failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SouthEndMusic SouthEndMusic SouthEndMusic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@visr @SouthEndMusic