Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixi run --environment=dev install to pixi run install #1400

Closed
wants to merge 7 commits into from

Conversation

Jingru923
Copy link
Contributor

Fixes #1324

@@ -37,7 +37,7 @@ jobs:
with:
pixi-version: "latest"
- name: Prepare pixi
run: pixi run --environment=dev install-ci
run: pixi run install install-ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: pixi run install install-ci
run: pixi run install-ci

Same for the others

pixi.toml Outdated
@@ -13,15 +13,19 @@ documentation = "https://deltares.github.io/Ribasim/"
repository = "https://github.com/Deltares/Ribasim"

[tasks]
install-ribasim-python ={ path = "python/ribasim", editable = true }
install-ribasim-api ={ path = "python/ribasim_api", editable = true }
install-ribasim-testmodels ={ path = "python/ribasim_testmodels", editable = true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With editable installs the installation is no longer done with a task, but automatically if listed under pypi dependencies. See Deltares/Ribasim-NL#75 for an example.

@Jingru923
Copy link
Contributor Author

This issue is paused. After pixi made a new release, I will put it to windows agent, Maarten takes care of Linux agents, I will ask Willem to run the pixi ansible role on the windows agents.

@visr
Copy link
Member

visr commented Apr 26, 2024

Pixi release is done: https://github.com/prefix-dev/pixi/releases/tag/v0.20.1

@Jingru923
Copy link
Contributor Author

Small update: The pixi version is updated for the windows agents. Now we are waiting for @evetion to update it for the Linux ones

Jingru923 added a commit that referenced this pull request May 6, 2024
Jingru923 added a commit that referenced this pull request May 8, 2024
…pixi install tasks" with new pixi release (#1455)

Fixes #1324 stop explicitly requiring `--environment=dev

And reimplement all the changes in PR #1400
@Jingru923 Jingru923 closed this May 8, 2024
@Jingru923 Jingru923 deleted the pixi-install branch May 14, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop explicitly requiring --environment=dev when running pixi install tasks
3 participants