Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pixi task cache #1407

Merged
merged 10 commits into from
Apr 21, 2024
Merged

Use pixi task cache #1407

merged 10 commits into from
Apr 21, 2024

Conversation

Jingru923
Copy link
Contributor

Fixes #1308

@Jingru923 Jingru923 linked an issue Apr 18, 2024 that may be closed by this pull request
Take advantage of pixi's task caching #1308
Closed
@Hofer-Julian Hofer-Julian changed the title task cache for generate-testmodels Task cache for generate-testmodels Apr 19, 2024
@Hofer-Julian Hofer-Julian changed the title Task cache for generate-testmodels Use pixi task cache Apr 19, 2024
Hofer-Julian
Hofer-Julian reviewed Apr 19, 2024
View reviewed changes
pixi.toml Outdated Show resolved Hide resolved
Hofer-Julian
Hofer-Julian reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that I didn't add a typo by testing locally :)

  1. Run it
  2. Run it again (it should be cached)
  3. Change input or output
  4. Run it again (it should not be cached)

pixi.toml Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
@Jingru923 Jingru923 marked this pull request as ready for review April 19, 2024 12:08
@Jingru923 Jingru923 requested a review from Hofer-Julian April 19, 2024 12:08
Hofer-Julian
Hofer-Julian suggested changes Apr 19, 2024
View reviewed changes
pixi.toml Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
Hofer-Julian
Hofer-Julian reviewed Apr 19, 2024
View reviewed changes
pixi.toml Outdated Show resolved Hide resolved
@Hofer-Julian Hofer-Julian mentioned this pull request Apr 19, 2024
Closed
2 tasks
@Jingru923 Jingru923 requested a review from Hofer-Julian April 19, 2024 13:48
@Hofer-Julian Hofer-Julian merged commit f526e6f into main Apr 21, 2024
24 checks passed
@Hofer-Julian Hofer-Julian deleted the pixi-task-caching branch April 21, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Take advantage of pixi's task caching
2 participants
@Jingru923 @Hofer-Julian