Make LevelDemand min_level and max_level optional #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
commented
Apr 25, 2024
| @@ -93,7 +93,7 @@ function parse_static_and_time( | |||
|
|
|||
| errors = false | |||
| t_end = seconds_since(config.endtime, config.starttime) | |||
| trivial_timespan = [nextfloat(-Inf), prevfloat(Inf)] | |||
| trivial_timespan = [0.0, prevfloat(Inf)] | |||
There was a problem hiding this comment.
Without this change we would get a NaN instead of Inf from DataInterpolations.
visr
commented
Apr 25, 2024
core/src/util.jl
Outdated
There was a problem hiding this comment.
Returning a storage of 0 for levels below the bottom seems fine to me, and is needed to support -Inf min_level.
Co-authored-by: Bart de Koning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #1428 (comment)
This makes it easier to use LevelDemand in case you only care about a shortage or surplus situation.