Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show convergence bottleneck nodes to users #1440

Merged
merged 14 commits into from
May 8, 2024
Merged

Show convergence bottleneck nodes to users #1440

merged 14 commits into from
May 8, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic commented Apr 29, 2024 •
edited
Loading

Fixes #452.

To do:

@SouthEndMusic SouthEndMusic marked this pull request as draft April 29, 2024 13:43
@SouthEndMusic SouthEndMusic changed the title Add unstable test model Show convergence bottleneck nodes to users Apr 29, 2024
@SouthEndMusic
Copy link
Collaborator Author

SouthEndMusic commented May 6, 2024 •
edited
Loading

I've implemented this now, but the result is not what I expect. The problematic basins (which get drained extremely quickly) in the test model have error $0$, and the others have some positive error. We need to think about under which circumstances, say which values of retcode this method makes sense.

Edit: I get the expected basins now.

visr
visr reviewed May 6, 2024
View reviewed changes
core/test/validation_test.jl Outdated Show resolved Hide resolved
@SouthEndMusic SouthEndMusic marked this pull request as ready for review May 7, 2024 10:39
@SouthEndMusic SouthEndMusic requested a review from evetion May 7, 2024 10:41
@Jingru923 Jingru923 self-requested a review May 7, 2024 11:21
evetion
evetion approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@evetion evetion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SouthEndMusic SouthEndMusic merged commit 943c04c into main May 8, 2024
23 of 24 checks passed
@SouthEndMusic SouthEndMusic deleted the indicate_problematic_basins branch May 8, 2024 09:47
This was referenced Jul 18, 2024
Closed
Merged
SouthEndMusic pushed a commit that referenced this pull request Jul 22, 2024
@visr
Always show convergence bottlenecks (#1636)
bc97d23 
Fixes #1593. Follow-up of #1440.
@visr visr mentioned this pull request Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr left review comments

@evetion evetion evetion approved these changes

@Jingru923 Jingru923 Awaiting requested review from Jingru923

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show convergence bottleneck nodes to users
3 participants
@SouthEndMusic @visr @evetion