Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable validation in Ribasim python #1446

Merged
merged 4 commits into from
May 3, 2024
Merged

Conversation

Jingru923
Copy link
Contributor

Fixes #1333

@Jingru923 Jingru923 linked an issue May 1, 2024 that may be closed by this pull request
@Jingru923 Jingru923 requested a review from visr May 1, 2024 09:18
@Jingru923 Jingru923 changed the title 1333 re-enable validation in Ribasim python Re-enable validation in Ribasim python May 2, 2024
python/ribasim/ribasim/model.py Outdated Show resolved Hide resolved
python/ribasim/tests/test_model.py Outdated Show resolved Hide resolved
python/ribasim/tests/test_model.py Outdated Show resolved Hide resolved
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@visr visr merged commit 7fa68c7 into main May 3, 2024
24 checks passed
@visr visr deleted the 1333-re-enable-validation branch May 3, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable validation functions for Ribasim Python
2 participants