-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo the "stop explicitly requiring --environment=dev
when running pixi install tasks" with new pixi release
#1455
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d97d984
redo all the change in #1400
Jingru923 00e4dd4
change the open-vscode.bat back
Jingru923 821748e
update lock file
Jingru923 db5fed2
remove install-python in github action
Jingru923 555c635
safe to delete install python
Jingru923 7e6e476
Merge branch 'main' into new-pixi-install
Jingru923 0c72d64
Merge branch 'main' into new-pixi-install
Jingru923 ee3e034
adapt comment
Jingru923 868c194
fix julia test yml
Jingru923 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,8 +36,6 @@ jobs: | |
- uses: prefix-dev/[email protected] | ||
with: | ||
pixi-version: "latest" | ||
- name: Prepare pixi | ||
run: pixi run --environment=dev install-ci | ||
- name: Test Ribasim Core | ||
run: | | ||
pixi run test-ribasim-core-cov | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,8 +19,6 @@ jobs: | |
- uses: prefix-dev/[email protected] | ||
with: | ||
pixi-version: "latest" | ||
- name: Prepare pixi | ||
run: pixi run --environment=dev install-ci | ||
- name: Run mypy on python/ribasim | ||
run: | | ||
pixi run mypy-ribasim-python | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,8 +19,6 @@ jobs: | |
- uses: prefix-dev/[email protected] | ||
with: | ||
pixi-version: "latest" | ||
- name: Prepare pixi | ||
run: pixi run --environment=dev install-ci | ||
- name: Test if codegen runs without errors | ||
run: pixi run codegen | ||
- name: Ensure that no code has been generated | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,8 +29,6 @@ jobs: | |
- uses: prefix-dev/[email protected] | ||
with: | ||
pixi-version: "latest" | ||
- name: Prepare pixi | ||
run: pixi run --environment ${{ matrix.pixi-environment }} install-python | ||
- name: Test Ribasim Python | ||
run: pixi run --environment ${{ matrix.pixi-environment }} test-ribasim-python-cov | ||
- name: Upload coverage to Codecov | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,9 +25,6 @@ jobs: | |
- uses: prefix-dev/[email protected] | ||
with: | ||
pixi-version: "latest" | ||
- name: Prepare pixi | ||
run: | | ||
pixi run --environment=dev install-ci | ||
- name: Run tests | ||
run: pixi run test-ribasim-qgis-cov | ||
- name: Upload coverage to Codecov | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to check, but I think
pixi --environment=dev shell
is still needed here, just likeopen-vscode.bat
also still usingpixi run --environment=dev code .
.The reason is that
qgis
is only installed in thedev
environment.