Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to DataInterpolations v5 #1464

Merged
merged 1 commit into from
May 14, 2024
Merged

Move to DataInterpolations v5 #1464

merged 1 commit into from
May 14, 2024

Conversation

visr
Copy link
Member

@visr visr commented May 14, 2024

This was breaking for us since it removed a type alias that we defined in our const alias ScalarInterpolation and VectorInterpolation.

This also tightens some return types to those concrete aliases, and changes a LevelDemand field type from the abstract Vector{LinearInterpolation} to the concrete Vector{ScalarInterpolation}, which should help the compiler.

Closes #1461.

This was breaking for us since it removed a type alias that we defined in our const alias ScalarInterpolation and VectorInterpolation.

This also tightens some return types to those concrete aliases, and changes a LevelDemand field type from the abstract `Vector{LinearInterpolation}` to the concrete `Vector{ScalarInterpolation}`, which should help the compiler.
Copy link
Collaborator

@SouthEndMusic SouthEndMusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@visr visr merged commit db1d1ea into main May 14, 2024
24 checks passed
@visr visr deleted the data-interpolations branch May 14, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants