Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QGIS 'LevelDemand / static' schema #1489

Merged
merged 4 commits into from
May 21, 2024
Merged

Fix QGIS 'LevelDemand / static' schema #1489

merged 4 commits into from
May 21, 2024

Conversation

visr
Copy link
Member

@visr visr commented May 21, 2024

Found by @JvanHouwelingen.

@visr visr requested a review from SouthEndMusic May 21, 2024 11:41
Copy link
Collaborator

@SouthEndMusic SouthEndMusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@@ -858,6 +859,11 @@ demand | Float64
allocated | Float64
realized | Float64

::: {.callout-note}
The LevelDemand node allocations are listed as node type Basin.
This is because one LevelDemand node can control multiple Basins, and doesn't receive flow by itself.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

control might be a confusing word here

docs/core/usage.qmd Outdated Show resolved Hide resolved
@visr visr merged commit 343e0bb into main May 21, 2024
21 of 22 checks passed
@visr visr deleted the schema-fix branch May 21, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants