Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMI docs page #1521

Merged
merged 6 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions docs/contribute/bmi.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# Basic Model Interface (BMI)

For runtime data exchange and coupling with other kernels, the Julia kernel is wrapped in a Python API (`ribasim_api`) which implements the Basic Modelling Interface [BMI](https://bmi-spec.readthedocs.io/en/latest/).

## Functions

The following functions are available to interact with the Ribasim model"

signature | description
------------------------- | -------------
`initialize(config_path)` | Initialize a model from the path to the TOML configuration file
`finalize()` | Write all results to the configured files
`get_current_time()` | Get the current time of the Ribasim simulation
`get_end_time()` | Get the final time of the Ribasim simulation in seconds
`get_start_time()` | Get the start time of the Ribasim simulation (`0.0`)
`get_time_step()` | Get the proposed next internal Ribasim timestep
`get_time_units()` | Get the time unit (`s`)
`get_value_ptr(string)` | Get the pointer to a Ribasim internal array (see below)
`update()` | Set a single Ribasim internal time step
`update_until(time)` | Set Ribasim internal timesteps until the specified time

Depending on what is specified in the Ribasim TOML configuration file, Ribasim can internally have adaptive (non-constant) timesteps. `update_until` will always try to progress the Ribasim simulation to exactly the time specified. This however can fail for algorithms that only support a fixed timestep if that timestep does not fit into the interval until the specified time an integer amount of times.

## Data pointers

The following internal array data is exposed via the BMI using `get_value_ptr(string)`:

string | meaning | type | unit | sorted by
------------------------------- | -------------------------------------- | ------- | ------------ | ----------
`basin.storage` | storage per basin | Float64 | $m^3$ | basin node ID
`basin.level` | level per basin | Float64 | $m$ | basin node ID
`basin.infiltration` | infiltration per basin | Float64 | $m^3 s^{-1}$ | basin node ID
`basin.drainage` | drainage per basin | Float64 | $m^3 s^{-1}$ | basin node ID
`basin.infiltration_integrated` | time integrated infiltration per basin | Float64 | $m^3$ | basin node ID
`basin.drainage_integrated` | time integrated drainage per basin | Float64 | $m^3$ | basin node ID
`basin.subgrid_level` | subgrid level | Float64 | $m$ | subgrid ID
`user_demand.demand` | demand per node ID per priority | Float64 | $m^3 s^{-1}$ | user_demand node ID, priority index
`user_demand.realized` | time integrated intake flow per user | Float64 | $m^3$ | user_demand node ID

Additional notes:

- `user_demand.demand` yields the only 2D array, the other arrays are 1D. This array is indexed as `(node_idx, priority_idx)`
- The index of e.g. basins and user demand nodes needs to be inferred from the Ribasim input. The same holds for `priority_idx`, which is global over all subnetworks
- The `*_integrated` values are integrated from the start of the simulation onward. It might be beneficial to reset this to $0$ at certain times for long simulations to avoid loss of accuracy.
Copy link
Contributor

@gijsber gijsber Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to add a note indicating that the flows are averaged over the timestep (if I am correct from t-1 tot t)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is different between what is exposed via the BMI and what is in the output. The output gives averaged values, the BMI exposes an integrated value

Copy link
Collaborator Author

@SouthEndMusic SouthEndMusic Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That way the coupler has the freedom to decide over which period to average, and Ribasim doesn't have to worry about whether the coupler accesses the data before or after averaging

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you already indicate that `*_integrated' is the accumulation.
but your description of the other variables can be more precise, by indicating it is instantaneous, averaged or whatever it is. It now is still a bit open-ended

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, that can be its own column. The differences between the BMI exposed data and the output are also worth mentioning

2 changes: 1 addition & 1 deletion docs/contribute/index.qmd
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: "Contributing"

Ribasim welcomes contributions.

There is developer documentation for the [Julia core](core.qmd), [Python tooling](python.qmd), and the [QGIS plugin](qgis.qmd).
There is developer documentation for the [Julia core](core.qmd), the [Basic Model Interface (BMI)](bmi.qmd), [Python tooling](python.qmd), and the [QGIS plugin](qgis.qmd).
A guide on how to add a new node type to both is written in [adding node types](addnode.qmd).
[Release process](release.qmd) describes the steps to follow when creating a new Ribasim release.

Expand Down