Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert TeamCity xml configuration files to Kotlin #1546

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

Manangka
Copy link
Collaborator

@Manangka Manangka commented Jun 10, 2024

Fixes #

This commit replaces the the TeamCity configuration files written in xml with the newer format written in Kotlin.
This has several advantages:

  • Make the configuration files easier to read
  • Makes it easier to recognize duplicate code and extract them to templates
  • Makes it possible to share template between teams that also uses Kotlin
  • Makes it possible to write more complex configurations because the configuration files can now contain logic

The current versioned settings of Ribasim are set to the xml format. Therefor I couldn't test these changes in the existing Ribasim project. Instead I created a separate Ribasim_Sandbox project that is set to use the Kotlin format. The build seems ok. The reason I say ok is because I'm not able to test everything due to missing credentials which you cant copy between projects

When merging this commit to main we have to set the settings format in the versioned settings tab to Kotlin otherwise the builds will fail

@Manangka Manangka marked this pull request as ready for review June 10, 2024 15:21
@Manangka Manangka requested review from evetion and visr June 10, 2024 15:21
Copy link
Member

@evetion evetion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes more code readable, before I could just skip it because it was xml...

@Manangka Manangka merged commit 1633397 into main Jun 11, 2024
23 of 25 checks passed
@Manangka Manangka deleted the use_teamcity_kotlin_format branch June 11, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants