Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

level_demand can now be without max_level or min_level #1629

Merged
merged 6 commits into from
Jul 22, 2024
Merged

level_demand can now be without max_level or min_level #1629

merged 6 commits into from
Jul 22, 2024

Conversation

Jingru923
Copy link
Contributor

Fixes #1589

@Jingru923 Jingru923 requested a review from SouthEndMusic July 17, 2024 07:51
@Jingru923 Jingru923 linked an issue Jul 17, 2024 that may be closed by this pull request
Allow LevelDemand nodes with neither a min_level nor a max_level #1589
Closed
@Jingru923 Jingru923 changed the title add if statement to set storage from nan to inf level_demand can now be without max_level or min Jul 17, 2024
@Jingru923 Jingru923 changed the title level_demand can now be without max_level or min level_demand can now be without max_level or min_level Jul 17, 2024
SouthEndMusic
SouthEndMusic reviewed Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@SouthEndMusic SouthEndMusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice that we have this now, but you should also add a test where you run a model with the default min_level and max_level and check that there us no crash.

@Jingru923 Jingru923 requested a review from SouthEndMusic July 18, 2024 15:32
SouthEndMusic
SouthEndMusic approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@SouthEndMusic SouthEndMusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have one single suggestion.

core/test/allocation_test.jl Show resolved Hide resolved
@Jingru923 Jingru923 merged commit be3247c into main Jul 22, 2024
25 checks passed
@Jingru923 Jingru923 deleted the level-min-max branch July 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SouthEndMusic SouthEndMusic SouthEndMusic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow LevelDemand nodes with neither a min_level nor a max_level
2 participants
@Jingru923 @SouthEndMusic