Write output table with solver stats per saveat #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SouthEndMusic
changed the title
visr
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Does this look backwards over time, e.g. that a record for t_i, is over the period t_i-1 to t_i? It would be consistent with the other tables if it is over the coming period.
I think water_balance_calls can be a bit confusing, perhaps rhs_calls or f_calls would be better. Otherwise we encode our internal function name in our data model.
Jingru923
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1674.
Not sure how to test this?