Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub action for updating lockfiles #1701

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Update GitHub action for updating lockfiles #1701

merged 2 commits into from
Aug 11, 2024

Conversation

visr
Copy link
Member

@visr visr commented Aug 8, 2024

This now uses the newly documented way to do this: https://pixi.sh/latest/advanced/updates_github_actions/

The main benefit for us is that it outputs a human readable diff.

@visr
Copy link
Member Author

visr commented Aug 8, 2024

Hmm this doesn't seem to work yet, I triggered the action from this branch manually: https://github.com/Deltares/Ribasim/actions/runs/10301265855/job/28512425240

  × Cannot update pypi dependencies without first installing a conda prefix
  │ that includes python.

- name: Update lockfiles
run: |
set -o pipefail
pixi update --json --no-install | pixi exec pixi-diff-to-markdown >> diff.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pixi update --json --no-install | pixi exec pixi-diff-to-markdown >> diff.md
pixi update --json | pixi exec pixi-diff-to-markdown >> diff.md

Seems like --no-install doesn't work (always?) if pypi dependencies are involved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, thanks! It works now: #1708

Shall I add a line about this to https://pixi.sh/latest/advanced/updates_github_actions/?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will try to make a minimal reproducer first

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Hofer-Julian <[email protected]>
@visr visr merged commit 7022e81 into main Aug 11, 2024
31 checks passed
@visr visr deleted the use-pixi-update branch August 11, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants