Autogenerate the validation tables for Python #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evetion
reviewed
Sep 4, 2024
evetion
reviewed
Sep 4, 2024
evetion
reviewed
Sep 4, 2024
evetion
approved these changes
Sep 4, 2024
deltamarnix
reviewed
Sep 5, 2024
| @@ -49,6 +49,15 @@ end | |||
|
|
|||
| snake_case(sym::Symbol)::Symbol = Symbol(snake_case(String(sym))) | |||
|
|
|||
| "Convert a string from snake_case to CamelCase." | |||
| function camel_case(snake_case::AbstractString)::String | |||
There was a problem hiding this comment.
Take a look at titlecase
There was a problem hiding this comment.
If it should become CamelCase, I would probably go for: titlecase(), and then replace('_' => '')
There was a problem hiding this comment.
I want this function to return the same string when the input is already camel case.
Seems titlecase() is not able to do it because it treats CamelCase as one word and return Camelcase.
The old way is the same amount of lines but more robust
deltamarnix
reviewed
Sep 5, 2024
| '{{n[:name]}}': [ | ||
| {% for value in n[:connectivity] %} | ||
| '{{ value }}', | ||
| {% end %}], |
There was a problem hiding this comment.
There was a problem hiding this comment.
Good source! In this case the white space trimming doesn't do much, because after ruff formatting the code, the code looks the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1779