Run quick start in docs #1811
Merged
Run quick start in docs #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
commented
Sep 19, 2024
docs/reference/node/basin.qmd
Outdated
| potential_evaporation | Float64 | $\text{m}/\text{s}$ | non-negative | ||
| drainage | Float64 | $\text{m}^3/\text{s}$ | non-negative | ||
| infiltration | Float64 | $\text{m}^3/\text{s}$ | non-negative | ||
| precipitation | Float64 | $\text m}/\text{s}$ | non-negative |
There was a problem hiding this comment.
This removes the opening braces.
There was a problem hiding this comment.
Reverted the commit, and fixed in 3c86334.
I tried find and replace with regex in VS Code, but couldn't find any matches, probably since the notebooks are JSON encoded. Though if I then searched for the JSON encoding in VS Code that was also buggy, so I did it in trusty Notepad++
This reverts commit 394df61.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1807.
Rather than having docs with code that doesn't run and output in static images, this intends to run the notebook as part of the docs generation just like example.ipynb.
I am also making more edits which I'll describe later.