Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explanation of water balance error #1828

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Add explanation of water balance error #1828

merged 5 commits into from
Sep 23, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #1820.

@SouthEndMusic SouthEndMusic requested a review from visr September 19, 2024 12:33
visr
visr approved these changes Sep 19, 2024
View reviewed changes
docs/concept/equations.qmd Outdated Show resolved Hide resolved
docs/concept/equations.qmd Outdated Show resolved Hide resolved
docs/concept/equations.qmd Outdated Show resolved Hide resolved
docs/concept/equations.qmd Outdated Show resolved Hide resolved
docs/concept/equations.qmd Outdated Show resolved Hide resolved
docs/concept/equations.qmd Outdated Show resolved Hide resolved
docs/reference/usage.qmd Outdated Show resolved Hide resolved
docs/concept/equations.qmd Outdated Show resolved Hide resolved
@SouthEndMusic
Copy link
Collaborator Author

SouthEndMusic commented Sep 19, 2024 •
edited
Loading

Todo do:

  • Add explanation of callback check
  • In usage.qmd: add explanation of water balance tolerance options (too large error probably indicates error in the code or floating point errors)

@visr visr mentioned this pull request Sep 23, 2024
Closed
@visr visr merged commit 221d51b into main Sep 23, 2024
26 of 27 checks passed
@visr visr deleted the water_balance_error_exaplanation branch September 23, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add example how water balance error is computed
2 participants
@SouthEndMusic @visr