Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log NaN errors and limit output to top 5 #1836

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Don't log NaN errors and limit output to top 5 #1836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16f897d
Don't log NaN errors and limit output to top 5
visr Sep 23, 2024
4aafa94
Refactor
visr Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions core/src/logging.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,20 @@ function log_bottlenecks(model; converged::Bool)
# Indicate convergence bottlenecks if possible with the current algorithm
if hasproperty(cache, :nlsolver)
flow_error = @. abs(cache.nlsolver.cache.atmp / u)
perm = sortperm(flow_error; rev = true)
errors = Pair{Symbol, Float64}[]
for i in perm
error_count = 0
max_errors = 5
# Iterate over the errors in descending order
for i in sortperm(flow_error; rev = true)
node_id = Symbol(id_from_state_index(p, u, i))
error = flow_error[i]
if error < model.config.solver.reltol
isnan(error) && continue # NaN are sorted as largest
# Stop reporting errors if they are too small or too many
if error < model.config.solver.reltol || error_count >= max_errors
break
end
push!(errors, node_id => error)
error_count += 1
end
if !isempty(errors)
@logmsg level "Convergence bottlenecks in descending order of severity:" errors...
Expand Down