-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document parsing Delwaq results. #1845
Conversation
Hmm, I forgot that we can't plot results, as we haven't run Delwaq in our docs. |
After a discussion with @visr on this, we decided to upload the results of the Delwaq test to minio, and use that in our plots. It will lag behind somewhat, but that should be not matter too much for documentation purposes. For that purposes I've added a upload_benchmark.py script (named to mirror the get_benchmark one) and improved both scripts to be more configurable (using personal keys) and argparse, and adjusted the TC configuration to match. The scripts should all use environment variables IMHO, but I'll leave that to another issue, as an implementation of DVC will supersede those improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Co-authored-by: Martijn Visser <[email protected]>
And plot some, including: