Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of Base.RefValue fields #1954

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Get rid of Base.RefValue fields #1954

merged 1 commit into from
Nov 26, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #1952.

@SouthEndMusic SouthEndMusic requested a review from visr November 26, 2024 13:54
@SouthEndMusic SouthEndMusic changed the title Get rid of Base.RefValue fields Get rid of Base.RefValue fields Nov 26, 2024
visr
visr approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks more readable.

@SouthEndMusic SouthEndMusic merged commit b3b57b0 into main Nov 26, 2024
25 of 27 checks passed
@SouthEndMusic SouthEndMusic deleted the mutable_structs_with_const_fields branch November 26, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use mutable structs + const instead of Base.Refvalue fields
2 participants
@SouthEndMusic @visr