Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of specifying sources in allocation by edges #1956

Merged
merged 13 commits into from
Dec 3, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic commented Nov 26, 2024

Fixes #1953.

To do: come up with a unified way to handle deprecation, and incorporate this in the developer docs and release process. Maybe also use a 'deprecation' label instead of a 'breaking' label?

@SouthEndMusic SouthEndMusic marked this pull request as ready for review November 28, 2024 16:10
visr added a commit to Deltares/Ribasim-NL that referenced this pull request Dec 2, 2024
As of Deltares/Ribasim#1956 these are automatically inferred.
core/src/read.jl Outdated Show resolved Hide resolved
core/src/callback.jl Outdated Show resolved Hide resolved
@SouthEndMusic SouthEndMusic requested a review from visr December 3, 2024 14:31
@SouthEndMusic SouthEndMusic merged commit 5b5e99f into main Dec 3, 2024
27 of 28 checks passed
@SouthEndMusic SouthEndMusic deleted the remove_edge_sources branch December 3, 2024 15:05
visr added a commit to Deltares/Ribasim-NL that referenced this pull request Dec 9, 2024
@visr visr mentioned this pull request Dec 20, 2024
visr added a commit that referenced this pull request Dec 20, 2024
Fixes #1978
In #1956 we forgot to update the schema version. Due to this line:
https://github.com/Deltares/Ribasim/blob/18217f0a0065e93c076ee663db4f6f2057c139b1/python/ribasim/ribasim/input_base.py#L177
That means migration functions aren't called. This fixes that. I also
added some extra comments on keeping them synced, and make the schema
version checks a bit more consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of specifying sources in allocation by edges
2 participants