calculate storage from Basin / profile #280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225
This removes the need to provide the storage for a profile. We can calculate it ourselves by integrating over A(h) to get A(S) and h(S).
First this updates the test models to a correct storage in the profile. Then we calculate the profile and get the same results. Then we remove the storage from the schemas and docs.
I hoped this would help with #80 but based on the plot I added there it doesn't seem to. This does not yet add all the validation and extrapolation for lookup tables as described in #279, that can be done separately.