Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove outdated plots from README #586

Merged
merged 3 commits into from
Sep 12, 2023
Merged

remove outdated plots from README #586

merged 3 commits into from
Sep 12, 2023

Conversation

visr
Copy link
Member

@visr visr commented Sep 11, 2023

Mainly want to see if CI is ok, seeing some GeoPackage time related issues locally.

Mainly want to see if CI is ok, seeing some GeoPackage time related issues locally.
This is already covered by the assert_equal, but gives a much better error message.
@visr
Copy link
Member Author

visr commented Sep 11, 2023

It failing locally but not on CI. I just added a test in bf6ba43, that locally gives:

AssertionError: assert Timestamp('2020-01-01 00:00:00') == Timestamp('2019-12-31 23:00:00')

Meaning that when we write the basic_transient model to disk, then read it back in again, the forcing shifted to one hour earlier. Note that the tests only improves the error message, the following test always covered this. So why is this suddenly an issue? Is it a daylight savings thing?

It looks like this also causes the core tests to fail for me locally. Though the source of the problem lies on the Python side. I'm running the latest pandas, v2.1.0, which is 2 weeks old.

Yes, indeed downgrading pandas to 2.0.3 fixes the issue. From the changelog quite some work was done on timezones and such, so it's probably related to that:

EDIT: it is pandas-dev/pandas#54877, we have to wait for pandas v2.1.1, which will include the fix.

Copy link
Member

@evetion evetion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will miss those pictures, it has a nice concrete feel to it. Maybe we need a new (QGIS based?) picture that shows what you can do with Ribasim.

@visr
Copy link
Member Author

visr commented Sep 12, 2023

Ha ok you are right, let's wait with removing until we have something else, see #590.
Now this is only adding a test.

@visr visr merged commit b8a9fe6 into main Sep 12, 2023
16 checks passed
@visr visr deleted the visr-patch-1 branch September 12, 2023 13:08
visr added a commit that referenced this pull request Sep 12, 2023
A regression breaks writing timestamps to GeoPackage for us:
pandas-dev/pandas#54877

Found in
#586 (comment)
visr added a commit that referenced this pull request Sep 14, 2023
Mainly want to see if CI is ok, seeing some GeoPackage time related
issues locally.
visr added a commit that referenced this pull request Sep 14, 2023
A regression breaks writing timestamps to GeoPackage for us:
pandas-dev/pandas#54877

Found in
#586 (comment)
This was referenced Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants