clamp reduction_factor and add it to TabulatedRatingCurve #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should not occur, but easy enough to prevent it.
If the rating curve prescribes large Q even when the upstream Basin is nearly empty, this leads to an incorrect water balance.
visr
added a commit
that referenced
this pull request
Sep 14, 2023
If the rating curve prescribes large Q even when the upstream Basin is nearly empty, this leads to an incorrect water balance. Replaces #562.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the rating curve prescribes large Q even when the upstream Basin is nearly empty, this leads to an incorrect water balance.
Replaces #562.