Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add runstats utility #611

Merged
merged 1 commit into from
Sep 22, 2023
Merged

add runstats utility #611

merged 1 commit into from
Sep 22, 2023

Conversation

visr
Copy link
Member

@visr visr commented Sep 22, 2023

This addresses a part of #462. It is a way to run and log performance related characteristics into a table. That table can then be used to do further analysis on what the effects of e.g. code changes or solver settings are.

This does not yet hook it up to anything, so there is the possibility for bitrot. But I've had this locally for a while, and I wanted to share it. Even if this doesn't run in TeamCity every week it can be useful for local analysis.

There are many columns, and one row per run, so a small part of the table looks like:

image

Columns are about solver settings, host machine, julia version, git commit, timing and GC.

@visr visr requested a review from Hofer-Julian September 22, 2023 10:09
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only found one stray commented piece of code.

Regarding TeamCity, we might get away with modifying the ribasim_cli tests a bit.
TeamCity already records the duration for each test:

grafik


tbl = Tables.columntable(runs)

# Arrow.append("runs.arrow", tbl)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove this comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I currently expect it to be used it by making some edits to the script as needed by your application. In some cases you want to re-run it and append runs to the table after e.g. checking out a different commit. In that case you'd want this line.

@visr
Copy link
Member Author

visr commented Sep 22, 2023

TeamCity already records the duration for each test

Good to know. By running from Julia we do have access to many more outputs, which we store here. That was the main reason for writing this in Julia.

@visr visr merged commit c193294 into main Sep 22, 2023
18 checks passed
@visr visr deleted the runstats branch September 22, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants