CompatHelper: bump compat for SciMLBase to 2 for package core, (keep existing compat) #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
visr
force-pushed
the
compathelper/new_version/2023-09-23-00-18-31-595-00777266716
branch
from
75da500 to
f74de9f
Compare
visr
approved these changes
Sep 23, 2023
visr
deleted the
compathelper/new_version/2023-09-23-00-18-31-595-00777266716
branch
|
Sorry, why are we merging PRs that break our CI? 😅 |
|
If I understand correctly CompatHelper CI forces the use of SciMLBase 2. We are compatible with it, but ComponentArrays is not yet. That is fine, since that will mean that we won't get it yet under normal circumstances. Hence this failed the Julia tests in this PR CI, but on main after merging this it isn't broken. It's a bit funny. I see that pixi on MacOS is broken in our Python tests on main after this PR was merged, but that seems unrelated: https://github.com/Deltares/Ribasim/actions/runs/6282043564/job/17061063657 |
|
Ah interesting. I restarted the failed tests, let's see if that helps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
SciMLBasepackage from1.60to1.60, 2for package core.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.