Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Basin / forcing to Basin / time #622

Merged
merged 1 commit into from
Sep 25, 2023
Merged

rename Basin / forcing to Basin / time #622

merged 1 commit into from
Sep 25, 2023

Conversation

visr
Copy link
Member

@visr visr commented Sep 25, 2023

All other node types use the table name "time" to represent time-varying data, as opposed to the static table. I've been wanting to rename this for a while, best not to postpone it more, because of the breaking change.

All other node types use the table name "time" to represent time-varying data, as opposed to the static table. I've been wanting to rename this for a while, best not to postpone it more, because of the breaking change.
@visr visr added the breaking A change that breaks existing models label Sep 25, 2023
Copy link
Collaborator

@SouthEndMusic SouthEndMusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@visr visr merged commit afbb33c into main Sep 25, 2023
18 checks passed
@visr visr deleted the forcing branch September 25, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A change that breaks existing models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants