Add dependency on testmodel for build binary tasks #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testmodels need to be present for the build process to work
visr
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Right, this is because we run a test model as a precompilation step in https://github.com/Deltares/Ribasim/blob/main/build/create_binaries/precompile.jl to make sure the binaries start more quickly since more of the code is already compiled.
visr
pushed a commit
that referenced
this pull request
Oct 17, 2023
The testmodels need to be present for the build process to work I've also formatted, so the diff is slightly bigger than expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testmodels need to be present for the build process to work
I've also formatted, so the diff is slightly bigger than expected