Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine edge labels #683

Merged
merged 1 commit into from
Oct 25, 2023
Merged

refine edge labels #683

merged 1 commit into from
Oct 25, 2023

Conversation

visr
Copy link
Member

@visr visr commented Oct 19, 2023

Fixes #175
Most of the work for this was already done in #658.

This changes a few things:

  • Stop using brackets around the ID to reduce visual clutter: now we use "Lake IJssel" #10 in printed errors and Lake IJssel #10 as a QGIS label
  • Add the edge ID to the label, this is the part that fixed Labeling of edges #175
  • Stop putting random strings as names in our basic test model
  • Add some real names to our Dutch waterways test model

image

Copy link
Member

@evetion evetion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna miss my random names.

Besides, there's an Arhnem in the screenshot, what's up with that?

@visr visr merged commit 2d3b6d6 into main Oct 25, 2023
15 checks passed
@visr visr deleted the label-edges branch October 25, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labeling of edges
2 participants