Fix CLI tests #691
Merged
Fix CLI tests #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
reviewed
Oct 23, 2023
| model = model_constructor() | ||
| assert isinstance(model, ribasim.Model) | ||
| model.write(tmp_path / model_name) | ||
| model.write(tmp_path) |
There was a problem hiding this comment.
With this the model folder name becomes a random tmp_path instead of the model name. That makes it hard to find the right model for manual inspection.
There was a problem hiding this comment.
tmp_path isn't random.
It gets the name according to the test parameters
There was a problem hiding this comment.
Would you be able to recognize the model name from the tmp_path, so does it put the constructor.__name__ in there? If so that would be great.
There was a problem hiding this comment.
It does on my machine.
But please, try it out yourself :)
There was a problem hiding this comment.
Nice. I couldn't afford to download new binaries over 4G to test 😓
visr
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #690