pixi: Update registry before instantiating #693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what's wise here. Instantiate should do this automatically, but the reason for this PR is that we observed once that didn't happen. Perhaps we should check if we can reproduce it first? If we do this, I'd probably prefer using the keyword argument |
That is already the default value, so I assume if there's a bug it is deeper in the code. I am actually fine either way, when I opened the PR I didn't know yet that this was supposed to be automatic. |
|
Shall we just close this then? If it happens again it's relatively easy to tell since it will tell you that new versions you require don't exist. |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.