use a TimeZones.jl fork for now #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative to #687, which wasn't working well with PackageCompiler due to long paths still. This switches to a fork. A PR to merge this upstream has already been submitted: JuliaTime/TimeZones.jl#450 Clearly this is temporary, but since we use Manifests this should work ok.
Hofer-Julian
approved these changes
Oct 25, 2023
Has some seemingly important Windows fixes: https://github.com/JuliaLang/PackageCompiler.jl/releases/tag/v2.1.11
|
It seems like this didn't solve the long path problem :( |
|
Actually I think both #687 and this PR solved the long path problem, but old artifacts with long paths from previous builds are causing issues. Maybe it's time for clean checkout... |
|
Will try that. |
|
Looks like 72faf45 worked, right? Should we enable that for all Ribasim jobs? |
|
Yeah, I'll enable it for everything now. |
visr
added a commit
that referenced
this pull request
Oct 25, 2023
Alternative to #687, which wasn't working well with PackageCompiler due to long paths still, leading to broken builds. This switches to a fork. A PR to merge this upstream has already been submitted: JuliaTime/TimeZones.jl#450 Clearly this is temporary, but since we use Manifests this should work ok.
Hofer-Julian
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #687, which wasn't working well with PackageCompiler due to long paths still, leading to broken builds.
This switches to a fork. A PR to merge this upstream has already been submitted: JuliaTime/TimeZones.jl#450
Clearly this is temporary, but since we use Manifests this should work ok.