-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow control of *Resistance and FractionalFlow #716
Conversation
The initial fractions come from whatever happens to be the last control state per node, and therefore can trigger false positive validation errors. Now we validate this per control state. To make that work I had to add the missing control state to the `control_mapping`. For simplicity I coalesce a missing `control_state` to the empty string. I wonder if that is the right approach though, since for e.g. name we default to the empty string rather than support missing. We should probably settle on either for all string columns.
Copying commit message a52d490 for visibility:
@evetion what do you recommend for missing / default string columns; |
This fixes a ``` BoundsError: attempt to access 2-element Vector{String} at index [4] ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (:
For naming things, so which not influence the numerics, I'm fine with "". Otherwise I like the explicit handling of missing with coalesce. |
Fix #718
Fix #722
Not sure if this works yet or if the validation is just too strict. Before merging this should be covered by a test model.