Add fair distribution options #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To do: remove demands as capacity constraints, are now in objective function. |
|
As a follow-up to #743 (comment), here are some allocation results that are more fair:
|
|
Nice :-). in quadratic_relative, is 5 going up or 6 going down? |
visr
reviewed
Nov 16, 2023
visr
approved these changes
Nov 20, 2023
This runs our tests on 8 workers. I haven't played around with the number yet, but as-is this is over 2x faster locally. It uses https://github.com/JuliaTesting/ReTestItems.jl/. This runs each testitem in a separate module. Before we were using SafeTestSets to run each test file in a separate module. Therefore some changes were needed, to make each item self-contained. Possibly we can make things a bit nicer with the `testsetup` macro as well. This also collects the output, so overall seems a lot more like our pytest setup. It also makes it easier to run a part of the tests with a regex or tag. I removed the TeamCity and TimerOutput tests, since they were just a PoC and not actually used. I we bring the XML report back we should probably use the [ReTestItems report keyword](https://github.com/JuliaTesting/ReTestItems.jl/blob/7bdf3bb79c756555bb9a55e2902a21b413fae8d3/src/ReTestItems.jl#L157). --------- Co-authored-by: Maarten Pronk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #726.