-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allocation diagram #771
Allocation diagram #771
Conversation
Here is a first draft of a diagram of the interaction between the Ribasim simulation and the allocation optimization. @visr @deltamarnix I would like to hear your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice to have! The diagram matches my understanding as well, left a few minor comments.
Hey that's a good start! I would like to see in the image maybe:
Good use of dashed arrows and activity bars! |
@deltamarnix go wild :) |
One could argue that the latest version above contains to much detail for where it is in the docs. Maybe this version could be in the developer docs and a stripped version where this one is now |
Maybe a simple flowchart for the other part? flowchart LR
Start((Start))
Allocate
Simulate
Timestep{Timestep ready?}
Finished{Finished?}
Done((Done))
Start --> Allocate
Allocate --> Simulate
Simulate --> Timestep
Timestep -->|no| Simulate
Timestep -->|yes| Finished
Finished -->|no| Allocate
Finished -->|yes| Done
|
Fixes #761.