Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocation diagram #771

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Allocation diagram #771

merged 5 commits into from
Nov 16, 2023

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #761.

@SouthEndMusic SouthEndMusic marked this pull request as draft November 10, 2023 16:11
@SouthEndMusic
Copy link
Collaborator Author

Here is a first draft of a diagram of the interaction between the Ribasim simulation and the allocation optimization. @visr @deltamarnix I would like to hear your feedback.

sim_and_opt_diagram

Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice to have! The diagram matches my understanding as well, left a few minor comments.

docs/core/allocation.qmd Outdated Show resolved Hide resolved
docs/core/allocation.qmd Outdated Show resolved Hide resolved
docs/core/allocation.qmd Outdated Show resolved Hide resolved
@deltamarnix
Copy link
Contributor

Hey that's a good start! I would like to see in the image maybe:

  • Are these two loops themselves also looped? Or is this really one time only?
  • How is the allocation process started? There must be some starting point in the code.
  • Are the Ribasim process and the allocation process really two different executables/processes. Or are we talking about modules within the same application?

Good use of dashed arrows and activity bars!

@SouthEndMusic
Copy link
Collaborator Author

@deltamarnix go wild :)

@SouthEndMusic
Copy link
Collaborator Author

Updated version:

sim_and_opt_diagram

@SouthEndMusic SouthEndMusic requested a review from visr November 14, 2023 10:24
@SouthEndMusic SouthEndMusic marked this pull request as ready for review November 14, 2023 10:25
@SouthEndMusic
Copy link
Collaborator Author

One could argue that the latest version above contains to much detail for where it is in the docs. Maybe this version could be in the developer docs and a stripped version where this one is now

@deltamarnix
Copy link
Contributor

deltamarnix commented Nov 14, 2023

Maybe a simple flowchart for the other part?

flowchart LR
Start((Start))
Allocate
Simulate
Timestep{Timestep ready?}
Finished{Finished?}
Done((Done))

Start --> Allocate
Allocate --> Simulate
Simulate --> Timestep
Timestep -->|no| Simulate
Timestep -->|yes| Finished
Finished -->|no| Allocate
Finished -->|yes| Done
Loading
flowchart LR
Start((Start))
Allocate
Simulate
Timestep{Timestep ready?}
Finished{Finished?}
Done((Done))

Start --> Allocate
Allocate --> Simulate
Simulate --> Timestep
Timestep -->|no| Simulate
Timestep -->|yes| Finished
Finished -->|no| Allocate
Finished -->|yes| Done

@visr visr merged commit 52090e1 into main Nov 16, 2023
15 checks passed
@visr visr deleted the allocation_diagram branch November 16, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a diagram of allocation
3 participants