Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getindex of local truth_values with global condition_idx #772

Closed
wants to merge 32 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
a5cd605
pixi: Instantiate consistently (#717)
Hofer-Julian Oct 31, 2023
31275b7
Update to python 3.12, pandas 2.1.2 (#713)
visr Oct 31, 2023
5065be9
Update pre-commit hooks (#724)
github-actions[bot] Nov 1, 2023
14ae29e
Use actions-gh-pages (#725)
Hofer-Julian Nov 1, 2023
5b25a62
Fix quarto publish path
Hofer-Julian Nov 1, 2023
61b2ec4
Back to LP solve per priority (#715)
SouthEndMusic Nov 3, 2023
40400f1
Work around quarto in a cross-platform way (#734)
Hofer-Julian Nov 3, 2023
3f4a15d
Fix rendering docs to PDF (#735)
SouthEndMusic Nov 3, 2023
1627c0c
docs: Fix `quarto-preview` (#741)
Hofer-Julian Nov 6, 2023
6f48d5f
Fix rendering docs to PDF (#737)
SouthEndMusic Nov 6, 2023
d7cabcf
set FractionalFlow inflow equal to outflow (#736)
visr Nov 6, 2023
d240a58
Add compat entries for stdlibs (#739)
visr Nov 6, 2023
fda99d3
Fix test-ribasim-core by adding `using Pkg;` (#742)
deltamarnix Nov 6, 2023
045d9c7
Add installation instructions for `ribasim_api` (#749)
Hofer-Julian Nov 7, 2023
ca9fc6f
Streamline release process to PyPI (#750)
Hofer-Julian Nov 7, 2023
0cba3d6
Add quarto and toml as vs code plugin recommends (#752)
deltamarnix Nov 7, 2023
f1ba4b2
TeamCity change in 'Ribasim / Ribasim' project: runners of 'Build lib…
Nov 8, 2023
a673b6a
TeamCity change in 'Ribasim / Ribasim' project: runners of 'Build rib…
Nov 8, 2023
1827d5c
TeamCity change in 'Ribasim / Ribasim' project: runners of 'Build lib…
Nov 8, 2023
6194502
TeamCity change in 'Ribasim / Ribasim' project: runners of 'Build lib…
Nov 8, 2023
47aa680
Share manifests (#740)
visr Nov 9, 2023
2c7e246
CompatHelper: bump compat for Documenter to 1 for package docs, (keep…
github-actions[bot] Nov 10, 2023
95d552b
CompatHelper: add new compat entry for SciMLBase at version 2 for pac…
github-actions[bot] Nov 10, 2023
92478c7
CompatHelper: add new compat entry for TerminalLoggers at version 0.1…
github-actions[bot] Nov 10, 2023
8366c28
move build code into create_binaries package (#762)
visr Nov 10, 2023
0828b17
update to ruff 1.5, add notebook settings (#763)
visr Nov 10, 2023
3e1d6b9
update to pixi 0.6 (#767)
visr Nov 10, 2023
5f8fe1b
Allocation output file (#743)
SouthEndMusic Nov 10, 2023
316f0f0
Switch to Julia 1.10-rc1 (#738)
visr Nov 10, 2023
70a302d
C4 diagrams (#770)
deltamarnix Nov 10, 2023
98b30d6
Fix getindex of local `truth_values` with global `condition_idx`
visr Nov 10, 2023
0ccc5fe
test multiple control nodes
visr Nov 13, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/core_compat_helper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,13 @@ jobs:
- name: "Run CompatHelper"
run: |
import CompatHelper
CompatHelper.main(; subdirs=["core"])
CompatHelper.main(; subdirs=[
"core",
"docs",
"build/create_binaries",
"build/libribasim",
"build/ribasim_cli"
])
shell: julia --color=yes {0}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/core_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
fail-fast: false
matrix:
julia_version:
- "1.9"
- "~1.10.0-0"
os:
- ubuntu-latest
- macOS-latest
Expand Down
11 changes: 4 additions & 7 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
matrix:
julia_version:
- "1.9"
- "~1.10.0-0"
arch:
- x64
steps:
Expand Down Expand Up @@ -53,14 +53,11 @@ jobs:
- name: Render Quarto Project
run: pixi run quarto-render

- name: Set up Quarto for publish
uses: quarto-dev/quarto-actions/setup@v2
- name: Publish Quarto Project
if: github.ref == 'refs/heads/main'
uses: quarto-dev/quarto-actions/publish@v2
uses: peaceiris/actions-gh-pages@v3
with:
path: docs
render: false
target: gh-pages
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./docs/_site
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/pre-commit_auto_update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
ssh-key: ${{ secrets.SSH_PRIVATE_KEY }}
- uses: actions/setup-python@v4
with:
python-version: "3.11"
python-version: "3.12"
- uses: browniebroke/pre-commit-autoupdate-action@main
- uses: peter-evans/create-pull-request@v5
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pre-commit_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: "3.11"
python-version: "3.12"
- uses: pre-commit/[email protected]
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,6 @@ dmypy.json
# Pyre type checker
.pyre/

# vscode
.vscode/settings.json

/.luarc.json
build/ribasim_cli/tests/temp/
python/ribasim_api/tests/temp/
Expand Down
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
rev: v4.5.0
hooks:
- id: check-added-large-files
- id: check-case-conflict
Expand All @@ -14,7 +14,7 @@ repos:
exclude: '.teamcity'
- id: trailing-whitespace
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.1.2
rev: v0.1.3
hooks:
- id: ruff
types_or: [python, pyi, jupyter]
Expand All @@ -26,6 +26,6 @@ repos:
hooks:
- id: nbstripout
- repo: https://github.com/crate-ci/typos
rev: v1.16.15
rev: v1.16.21
hooks:
- id: typos
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
<option name="executionTimeoutMin" value="120" />
</options>
<parameters>
<param name="conda_env_path" value="%system.teamcity.build.checkoutDir%/env_build_ribasim_cli" />
<param name="julia" value="%env.JULIA_1_9%" />
<param name="julia_dir" value="%env.JULIA_DIR_1_10%" />
</parameters>
<build-runners>
<runner id="RUNNER_2418" name="Set up pixi" type="simpleRunner">
Expand All @@ -23,8 +22,8 @@
</runner>
<runner id="RUNNER_2420" name="Build binary" type="simpleRunner">
<parameters>
<param name="script.content"><![CDATA[set Path=d:\ProgramData\julia/julia-1.9.0/bin/;%env.Path%
pixi run build-ribasim-cli]]></param>
<param name="script.content"><![CDATA[set Path=%julia_dir%;%env.Path%
pixi run build-ribasim-cli]]></param>
<param name="teamcity.build.workingDir" value="ribasim" />
<param name="teamcity.step.mode" value="default" />
<param name="use.custom.script" value="true" />
Expand Down Expand Up @@ -91,4 +90,3 @@ pixi run build-ribasim-cli]]></param>
<cleanup />
</settings>
</build-type>

Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
<setting-ref ref="RQ_271" />
</disabled-settings>
<parameters>
<param name="conda_env_path" value="%system.teamcity.build.checkoutDir%/env_build_libribasim" />
<param name="julia" value="%env.JULIA_1_9%" />
<param name="julia_dir" value="%env.JULIA_DIR_1_10%" />
</parameters>
<build-runners>
<runner id="RUNNER_2415" name="Set up pixi" type="simpleRunner">
Expand All @@ -27,7 +26,7 @@
</runner>
<runner id="RUNNER_2416" name="Build binary" type="simpleRunner">
<parameters>
<param name="script.content"><![CDATA[set Path=d:\ProgramData\julia/julia-1.9.0/bin/;%env.Path%
<param name="script.content"><![CDATA[set Path=%julia_dir%;%env.Path%
pixi run build-libribasim]]></param>
<param name="teamcity.build.workingDir" value="ribasim" />
<param name="teamcity.step.mode" value="default" />
Expand Down Expand Up @@ -82,4 +81,3 @@ pixi run build-libribasim]]></param>
<cleanup />
</settings>
</build-type>

4 changes: 3 additions & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
"ms-python.python",
"ms-python.mypy-type-checker",
"charliermarsh.ruff",
"njpwerner.autodocstring"
"njpwerner.autodocstring",
"quarto.quarto",
"tamasfe.even-better-toml"
]
}
5 changes: 4 additions & 1 deletion .vscode/settings_template.json → .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@
"[julia]": {
"editor.formatOnSave": true
},
"julia.environmentPath": "core",
"notebook.formatOnSave.enabled": true,
"notebook.codeActionsOnSave": {
"source.fixAll.ruff": true,
"source.organizeImports.ruff": true
},
"[python]": {
"editor.defaultFormatter": "charliermarsh.ruff",
"editor.formatOnSave": true,
Expand Down
Loading
Loading