lower reltol from 1e-3 to 1e-5 #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@harm-nomden-sweco shared a case where a pump is emptying a basin with an inflow smaller than the pump capacity. We know this case leads to small timesteps, but it appeared this also led to large errors in the water balance. This lowering of the reltol is enough to fix that issue. Since such a case can be common, it is good to have a safe default.
This also adds
using Testto all test files. Andtest/time.jlneeded some refactoring since there were a few sub-millisecond timesteps, whereas we round our time to milliseconds.