Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use TimeZones fork again #783

Merged
merged 1 commit into from
Nov 14, 2023
Merged

use TimeZones fork again #783

merged 1 commit into from
Nov 14, 2023

Conversation

visr
Copy link
Member

@visr visr commented Nov 14, 2023

To address an issue with running the same ribasim binary simultaneously from different workers.

  InitError(mod=:WindowsTimeZoneIDs, error=Base.IOError(msg="unlink("D:\\buildAgent\\work\\c463fd4bc9a9a18\\imod_collector_devel\\ribasim\\share\\julia\\scratchspaces\\f269a46b-ccf7-5d73-abea-4c690281aa53\\build\\local\\windowsZones.xml"): resource busy or locked (EBUSY)", code=-4082)

In making this PR I realized I forgot in #740 to actually run strip_cldr.

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@visr visr merged commit d6e585a into main Nov 14, 2023
15 checks passed
@visr visr deleted the branch-timezones branch November 14, 2023 14:20
@visr
Copy link
Member Author

visr commented Nov 14, 2023

@Hofer-Julian the general, upstream issue for race conditions on scratch spaces is JuliaPackaging/Scratch.jl#26.

@Hofer-Julian
Copy link
Contributor

@Hofer-Julian the general, upstream issue for race conditions on scratch spaces is JuliaPackaging/Scratch.jl#26.

Subscribed!

visr added a commit that referenced this pull request Nov 14, 2023
To address an issue with running the same ribasim binary simultaneously
from different workers.

```
  InitError(mod=:WindowsTimeZoneIDs, error=Base.IOError(msg="unlink("D:\\buildAgent\\work\\c463fd4bc9a9a18\\imod_collector_devel\\ribasim\\share\\julia\\scratchspaces\\f269a46b-ccf7-5d73-abea-4c690281aa53\\build\\local\\windowsZones.xml"): resource busy or locked (EBUSY)", code=-4082)
```

In making this PR I realized I forgot in #740 to actually run
`strip_cldr`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants