Prefix extra columns with meta_
#794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
reviewed
Nov 16, 2023
| TerminalStatic: TerminalStatic | None | ||
| UserStatic: UserStatic | None | ||
| UserTime: UserTime | None | ||
| basinprofile: BasinProfile | None = None |
There was a problem hiding this comment.
It's unused, the whole Root is there just to generate all child models from this single root definition.json.
|
Does the prefix now get added for all dataframes? |
Validation always runs, also on assignment, so yes. The only exception are the node and edge tables, which have no pydantic record (cause geometry fields couldn't be autogenerated). But feel free to test drive this. |
visr
approved these changes
Nov 16, 2023
visr
changed the title
meta_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #576
Required, but seemingly unrelated, fixes: