Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocation main network initialization #924

Merged

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #921.

@SouthEndMusic SouthEndMusic marked this pull request as draft January 8, 2024 15:05
@SouthEndMusic SouthEndMusic changed the title start finding main -> subnetwork connections Allocation main network initialization Jan 8, 2024
@SouthEndMusic SouthEndMusic linked an issue Jan 11, 2024 that may be closed by this pull request
4 tasks
@SouthEndMusic
Copy link
Collaborator Author

SouthEndMusic commented Jan 15, 2024

After doing a manual depth-first traversal of the call tree sprouting from function AllocationModel, I found the need for these modifications to support the main network:

  • In function allocation_graph_used_nodes!: Make sure that for each edge that connects the main network to a subnetwork, both nodes connected to this edge are used in the main network problem (which indeed means that the optimization problem for the main network considers some nodes which are not in the main network)
  • In function add_variables_absolute_value!: Use the outgoing node in the main-sub connection edges as a user for the main network
  • In function add_constraints_absolute_value!: Add constraints also for the nodes mentioned above.

Other functions in allocation.jl also need to be checked for whether they need updates to support the main network, but this is left for #922.

@SouthEndMusic SouthEndMusic marked this pull request as ready for review January 16, 2024 12:45
@SouthEndMusic SouthEndMusic requested a review from visr January 16, 2024 12:45
@SouthEndMusic SouthEndMusic marked this pull request as draft January 16, 2024 12:52
@SouthEndMusic SouthEndMusic marked this pull request as ready for review January 16, 2024 13:57
core/src/allocation.jl Outdated Show resolved Hide resolved
@SouthEndMusic SouthEndMusic merged commit ace1b83 into main_network_allocation_main Jan 16, 2024
15 checks passed
@SouthEndMusic SouthEndMusic deleted the main_network_allocation_init branch January 16, 2024 14:55
@SouthEndMusic SouthEndMusic restored the main_network_allocation_init branch February 1, 2024 15:14
@deltamarnix deltamarnix deleted the main_network_allocation_init branch February 2, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allocation main network initialization
2 participants