Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix looped subnetwork #965

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Fix looped subnetwork #965

merged 2 commits into from
Jan 17, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #692.

It now also runs fine with the cli (which I think I ran for the first time ever ^^).

@SouthEndMusic SouthEndMusic marked this pull request as draft January 17, 2024 11:52
@SouthEndMusic SouthEndMusic marked this pull request as ready for review January 17, 2024 11:57
@SouthEndMusic
Copy link
Collaborator Author

@gijsber this fixes the allocation test model which you designed a while back:
looped_subnetwork

The allocation runs without errors. Maybe we should have a look at the actual allocation behavior.

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SouthEndMusic SouthEndMusic merged commit 76f4b32 into main Jan 17, 2024
17 of 18 checks passed
@SouthEndMusic SouthEndMusic deleted the looped_subnetwork_model branch January 17, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testmodel looped_subnetwork_model is not working
2 participants