Always write fid index of Node and Edge tables #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huite
approved these changes
Jan 26, 2024
|
|
||
| gdf.to_file(path, layer=self.tablename(), driver="GPKG") | ||
| gdf.to_file(path, layer=self.tablename(), driver="GPKG", index=True) |
There was a problem hiding this comment.
Mostly out of curiosty: What happens if index=True but no name is provided, does it error?
There was a problem hiding this comment.
Oef, then it writes the index to an index column, and still adds a 1-based autoincrement fid.
This is the trivial model, which has edge_id 9 and 11 only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
GeoDataFrame.to_fileto write these tables to GeoPackage. By default GeoPandas only writes the index if it has a name. We don't want to rely on users naming indices, so this sets the name and ensure it is written.I ran into this since I noticed the
model.network.edge.df.index(by default 0-based) did not correspond to the 1-based fid column that GeoPandas writes.https://geopandas.org/en/stable/docs/reference/api/geopandas.GeoDataFrame.to_file.html